Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove widget focused on selection #8199

Merged
merged 2 commits into from
Nov 26, 2024
Merged

refactor: remove widget focused on selection #8199

merged 2 commits into from
Nov 26, 2024

Conversation

tomivirkki
Copy link
Member

Description

Changes in this PR

  • Includes the invisible focus button to the focus trap container of a widget/section so that in selection mode, you can tab between the drag handle, remove button, resize handle and the focus button.
    • Clicking the focus button in selection mode exists selection mode
  • Remove the focused attribute from a widget in selection mode unless the focus button is focused

Type of change

Refactor

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tomivirkki tomivirkki merged commit 89e79cb into main Nov 26, 2024
9 checks passed
@tomivirkki tomivirkki deleted the refactor/remove-focused-on-select branch November 26, 2024 08:38
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.beta3 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ugur-vaadin ugur-vaadin ugur-vaadin approved these changes

@yuriy-fix yuriy-fix yuriy-fix approved these changes

@rolfsmeds rolfsmeds Awaiting requested review from rolfsmeds

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.6.0 Released with Vaadin 24.6.0.beta3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomivirkki @vaadin-bot @yuriy-fix @ugur-vaadin