refactor: ensure Lit month calendars are rendered synchronously #8220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
commented
Nov 25, 2024
| this._debouncerUpdateClones.cancel(); | ||
| } | ||
|
|
||
| if (this.__pendingFinishInit) { |
There was a problem hiding this comment.
note: Some tests finish before the _finishInit handler is executed. In such cases, we need to cancel its execution to prevent performUpdate from throwing an exception.
There was a problem hiding this comment.
IMO we should also consider updating these tests to wait for overlay open.
1 task
web-padawan
approved these changes
Nov 25, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.beta3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR refactors
date-pickerto ensure that the initial rendering of Lit month calendars happens synchronously. This eliminates rendering differences between the Lit and Polymer versions, which were causing test failures in #8187.Type of change