-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not dispatch event on stopedit when editor loading #8232
fix: do not dispatch event on stopedit when editor loading #8232
Conversation
Quality Gate passedIssues Measures |
We should fix the underlying issue of the Kapture.2024-11-27.at.10.47.54.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to treat the issue mentioned above as a separate topic. This change is overall an improvement to the current behavior and does fix what's described in vaadin/flow-components#6816 so let's merge it.
Hi @ugur-vaadin and @ugur-vaadin, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? |
This ticket/PR has been released with Vaadin 24.6.0.beta3 and is also targeting the upcoming stable 24.6.0 version. |
Description
When a slow custom editor is used, quickly tabbing through the cells can cause a false positive on cell value change since the editor value is not updated yet at that point. This leads to firing unnecessary
item-property-changed
events.This PR adds an editor loading check in
_stopEdit
in order to avoid firing the events. This is effectively the same as canceling the edit.Fixes #6816
Type of change
Checklist