Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Card slots #8233
base: main
Are you sure you want to change the base?
[feat] Card slots #8233
Changes from all commits
03b759c
af7e9c4
4b085d9
476f73b
0a6dcd2
906c67e
bf28c91
d5b3bad
7b0359b
52103aa
a441654
3ce3ebd
809aea2
66b8b4b
53a81fa
ebf16f9
32ea420
88ec3be
c457bff
8f0f7f7
46a67f0
97c0048
28eb9d4
e6f28c1
c97da29
e6307c9
d7f7e8b
f43304f
8f4e7ec
a93ebfd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this doesn't support plain text as card content, e.g. the following works:
But the following does not work (the content isn't visible):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to provide
has-
attributes for all browsers? This approach is widely used by existing components e.g.has-error-message
etc and IMO it would make card styling easier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be probably updated to check for the actual slotted nodes as
querySelector()
doesn't return text nodes from the default slot. I could change the logic to useSlotObserver
helper that we have since it provides the access to the list of current nodes usingslot.assignedNodes({ flatten: true })
.