Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract message styles into reusable CSS literal #8242

Merged
merged 2 commits into from
Nov 29, 2024
Merged

refactor: extract message styles into reusable CSS literal #8242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e28dcf
refactor: extract message styles into reusable CSS literal
web-padawan Nov 29, 2024
c5faa48
refactor: update message styles to fix Stylelint warnings
web-padawan Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/message-list/src/vaadin-message-styles.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/**
* @license
* Copyright (c) 2021 - 2024 Vaadin Ltd..
* This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
*/
import type { CSSResult } from 'lit';

export const messageStyles: CSSResult;
43 changes: 43 additions & 0 deletions packages/message-list/src/vaadin-message-styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/**
* @license
* Copyright (c) 2021 - 2024 Vaadin Ltd.
* This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
*/
import { css } from 'lit';

export const messageStyles = css`
:host {
display: flex;
flex-direction: row;
outline: none;
}

:host([hidden]) {
display: none !important;
}

[part='content'] {
display: flex;
flex-direction: column;
flex-grow: 1;
}

[part='header'] {
align-items: baseline;
display: flex;
flex-flow: row wrap;
}

[part='name'] {
font-weight: 500;
}

[part='message'] {
white-space: pre-wrap;
}

::slotted([slot='avatar']) {
--vaadin-avatar-outline-width: 0;
flex-shrink: 0;
}
`;
42 changes: 4 additions & 38 deletions packages/message-list/src/vaadin-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@ import '@vaadin/avatar/src/vaadin-avatar.js';
import { html, PolymerElement } from '@polymer/polymer/polymer-element.js';
import { defineCustomElement } from '@vaadin/component-base/src/define.js';
import { ElementMixin } from '@vaadin/component-base/src/element-mixin.js';
import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
import { registerStyles, ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
import { MessageMixin } from './vaadin-message-mixin.js';
import { messageStyles } from './vaadin-message-styles.js';

registerStyles('vaadin-message', messageStyles, { moduleId: 'vaadin-message-styles' });

/**
* `<vaadin-message>` is a Web Component for showing a single message with an author, message and time.
Expand Down Expand Up @@ -48,43 +51,6 @@ import { MessageMixin } from './vaadin-message-mixin.js';
class Message extends MessageMixin(ElementMixin(ThemableMixin(PolymerElement))) {
static get template() {
return html`
<style>
:host {
display: flex;
flex-direction: row;
outline: none;
}

:host([hidden]) {
display: none !important;
}

[part='content'] {
display: flex;
flex-direction: column;
flex-grow: 1;
}

[part='header'] {
align-items: baseline;
display: flex;
flex-direction: row;
flex-wrap: wrap;
}

[part='name'] {
font-weight: 500;
}

[part='message'] {
white-space: pre-wrap;
}

::slotted([slot='avatar']) {
--vaadin-avatar-outline-width: 0px;
flex-shrink: 0;
}
</style>
<slot name="avatar"></slot>
<div part="content">
<div part="header">
Expand Down