Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure ready() is called after observers #8254

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Dec 2, 2024

Description

Ensures that ready() is called only after all observers have been executed, including nested calls.

Extracted from #8223

Type of change

  • Bugfix

Copy link

sonarqubecloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@vursen vursen marked this pull request as ready for review December 2, 2024 06:25
Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll create separate PR to update time picker since apparently ready() can now be moved to the mixin as well.

@web-padawan web-padawan merged commit d5e20c6 into main Dec 2, 2024
8 of 9 checks passed
@web-padawan web-padawan deleted the fix/ensure-ready-is-called-after-observers branch December 2, 2024 09:35
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.beta3 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants