fix: observe internal layout to avoid problems with fixed height #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Can you remember why we change the opacity in the first place? The comment mentions something about "avoid jumps", but opacity doesn't affect the size of the element.
There was a problem hiding this comment.
The jump can happen e.g. in case from vaadin/flow-components#6728 (comment) when form layout becomes visible:
form-layout-jump.mp4
tomivirkki
approved these changes
Dec 5, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 5, 2024
…) (#8280) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
added a commit
that referenced
this pull request
Dec 5, 2024
…) (#8279) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
|
This ticket/PR has been released with Vaadin 24.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow#20598 (which is a regression from #7988)
This is a fix for the case when
vaadin-form-layoutheight is inherited from a fixed-size parent element (which is what happens in Flow due to the fact that it setsheight: 100vhon the<body>and outlet element).Currently, when scrolling long enough, the layout is becoming "not intersecting" and
opacityis wrongly set to 0. This change ensures thatIntersectionObserverinstead uses the internal element since its height is defined by content.Type of change