Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use underscore to indicate CSS variable is private #8286

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Dec 5, 2024

Description

Renamed ---level to --_level to align with our naming convention for private CSS variables.

Type of change

  • Refactor

@vursen vursen changed the title refactor: rename ---level CSS variable to --_level refactor: use underscore to indicate that CSS variable is private Dec 5, 2024
@vursen vursen changed the title refactor: use underscore to indicate that CSS variable is private refactor: use underscore to indicate CSS variable is private Dec 5, 2024
Copy link

sonarqubecloud bot commented Dec 5, 2024

@vursen vursen marked this pull request as ready for review December 5, 2024 13:23
@vursen vursen requested a review from web-padawan December 5, 2024 13:23
@vursen vursen merged commit 2dc2b64 into main Dec 5, 2024
9 checks passed
@vursen vursen deleted the refactor/replace-dash-with-underscore branch December 5, 2024 13:44
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants