fix: prevent notification from affecting overlay interactions #8291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
reviewed
Dec 6, 2024
vursen
approved these changes
Dec 6, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 6, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 6, 2024
|
Is this fix in 24.5.8? I believe it is not. If it is not, when is this expected to be fixed? |
|
It should land in the next patch release, which will hopefully be out this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8281
The change in #8198 introduced two regressions related to "notification" + "dialog" combination:
vaadin-notification-containeris now considered a "last" overlay so the keydown listener is not firing thus making it impossible to closevaadin-dialogon Esc if there is a notification on top of it,vaadin-notification-containeris treated as modal overlay (as it doesn't havemodeless) - as a result,pointer-events: noneis not removed from parent dialog if notification is open before closing nested dialog.This PR changes the logic to only include notification container in the "visual" stack (z-index) and adds separate helper that filters it out from
getAttachedInstances()so that overlay "modality" stack is not affected.Type of change