fix: do not fire custom-value-set on input blur or outside click #8308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/mscb-ignore-custom-value
branch
from
ebd3d49 to
a438139
Compare
vursen
reviewed
Dec 10, 2024
packages/multi-select-combo-box/src/vaadin-multi-select-combo-box-internal-mixin.js
Outdated
Show resolved
Hide resolved
Contributor
|
This change also prevents selection of list items on outside click and blur. Is that intended? Screen.Recording.2024-12-10.at.16.17.22.mov |
Member
Author
Checked this and it's also prevented in earlier versions e.g. |
Member
Author
|
Added tests to verify that focused item isn't selected on blur / outside click. |
|
vursen
approved these changes
Dec 10, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 10, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 10, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 10, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 10, 2024
…) (#8313) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
added a commit
that referenced
this pull request
Dec 11, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 11, 2024
web-padawan
added a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #8301
Fixes #8067
Fixes #3645
Changed the MSCB logic to discard custom value from the internal combo-box on input blur with Tab or outside click.
This would require user to explicitly commit custom value by pressing Enter after typing the filter in the input.
Type of change