Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only set avtar img src attribute if property is defined #8329

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

web-padawan
Copy link
Member

Description

Currently, in Lit version the empty src attribute is set by default (can be checked by snapshot test). This PR fixes that:

 ❌ vaadin-avatar > default
      AssertionError: Snapshot vaadin-avatar default does not match the saved snapshot on disk
      + expected - actual

       <img
         aria-hidden="true"
         draggable="false"
         hidden=""
      -  src=""
       >
       <slot name="tooltip">
       </slot>

Type of change

  • Bugfix

@web-padawan web-padawan requested a review from vursen December 12, 2024 09:24
@web-padawan web-padawan removed the request for review from vursen December 12, 2024 09:40
@web-padawan web-padawan merged commit e751f87 into main Dec 12, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/lit-avatar-if-defined branch December 12, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants