Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade playwright to 1.48.2 #8355

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

chore: upgrade playwright to 1.48.2 #8355

wants to merge 7 commits into from

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Dec 17, 2024 •
edited
Loading

@sissbruecker
Copy link
Contributor

We are still waiting for this to be fixed: microsoft/playwright#32269

@vursen vursen force-pushed the upgrade-playwright-version branch from 0075e0c to 12384a9 Compare December 18, 2024 09:52
@vursen vursen mentioned this pull request Dec 23, 2024
Merged
1 task
@vursen vursen force-pushed the upgrade-playwright-version branch from 925869b to b988e9d Compare December 23, 2024 10:40
@vursen vursen mentioned this pull request Dec 23, 2024
Open
@vursen vursen force-pushed the upgrade-playwright-version branch from 89241b7 to 4577f45 Compare December 24, 2024 07:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vursen
Copy link
Contributor Author

vursen commented Dec 24, 2024 

packages/icon/test/icon-font-polymer.test.js:

 ❌ vaadin-icon - icon fonts > sizing > should subtract vertical padding from height
      AssertionError: expected 24 to be close to 14 +/- 1
        at AssertionError (node_modules/assertion-error/index.js:15:14)
        at node_modules/chai/lib/chai/assertion.js:143:29
        at closeTo (node_modules/chai/lib/chai/core/assertions.js:3027:14)
        at methodWrapper (node_modules/chai/lib/chai/utils/addMethod.js:56:30)
        at packages/icon/test/icon-font.common.js:52:79

This failure is caused by #8397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @sissbruecker