fix: slot dashboard widgets instead of dom reordering #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
fix/dashboard-slot-widgets
branch
from
a7e9b88 to
c235998
Compare
tomivirkki
force-pushed
the
fix/dashboard-slot-widgets
branch
from
c235998 to
f2d2cb0
Compare
tomivirkki
requested review from
DiegoCardoso,
sissbruecker,
vursen and
web-padawan
vursen
reviewed
Dec 19, 2024
web-padawan
reviewed
Dec 19, 2024
vursen
reviewed
Dec 19, 2024
|
vursen
approved these changes
Dec 19, 2024
sissbruecker
approved these changes
Dec 19, 2024
web-padawan
approved these changes
Dec 19, 2024
sissbruecker
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
<vaadin-dashboard>to reorder the widgets by assigning them updatedslotnames instead of reordering the elements in the DOM. This will fix issues such as a<vaadin-grid>losing its scroll position on reorder when used as a widget child element.NOTE: This change will require picking up this commit to the web component version bump PR in
flow-componentsType of change
Bugfix/refactor