chore: update Chrome version in Material visual tests #8383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated screenshots that failed with upgrading Chrome version |
|
Looks like there are more failing tests in this version e.g. "error message" tests seem to be flaky. |
web-padawan
force-pushed
the
test/material-chrome
branch
from
d5249ea to
7760097
Compare
|
Rebased after merging #8396 which should fix flaky error message tests for Material, let's see if this passes now. |
|
vursen
reviewed
Dec 23, 2024
There was a problem hiding this comment.
For some reason, a border line is missing under "Hi, I'm Laura" now
|
The version was updated in #8415. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Out Material visual tests use Chrome 88 which doesn't support CSS properties like
border-start-end-radius.Updated to Chrome 93 for now. Using a more recent version causes a lot of size differences in fullscreen tests:
UPD: also changed
@fontsource/robotoversion inpackage.jsonto bumpyarn.lockwhich causes all visual tests to run in the PR validation (the actual version in the lockfile has been already updated to4.5.8previously anyway).Type of change