refactor: use div with heading role instead of h2 in form title #8441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/login-form-title-heading
branch
from
262be3f to
e1f351e
Compare
|
vursen
approved these changes
Jan 3, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 3, 2025
web-padawan
added a commit
that referenced
this pull request
Jan 3, 2025
… (#8442) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan
added a commit
that referenced
this pull request
Jan 3, 2025
… (#8443) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
|
This ticket/PR has been released with Vaadin 24.7.0.alpha3 and is also targeting the upcoming stable 24.7.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #98
See #98 (comment)
Type of change
Note
Internal HTML tag names are not considered public API and can be changed as long as part names remain intact.
So IMO we can consider this a non-breaking change and backport it to previous versions same as #8438.
I'll create a separate PR with a new property in order to customize the heading level, that will only target 24.7