Skip to content

experiment: add tabs base styles and visual tests #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jouni
Copy link
Member

@jouni jouni commented Jun 17, 2025

Screenshot 2025-06-17 at 16 12 39

Screenshot 2025-06-17 at 16 12 51

Built-In Variants

Name Description
hide-scroll-buttons Always hides the scroll buttons, also on devices with pointer: fine.
show-scroll-buttons Always shows the scroll buttons, also on devices with pointer: coarse (touch devices).

Supported Custom Properties

Tab

Property Fallback value
--vaadin-tab-gap Gap between tab icon and label.
--vaadin-tab-padding
--vaadin-tab-font-size
--vaadin-tab-font-weight
--vaadin-tab-line-height
--vaadin-tab-color
--vaadin-tab-background
--vaadin-tab-border-radius

Tabs container

Property Fallback value
--vaadin-tabs-gap Gap between tabs.

@jouni
Copy link
Member Author

jouni commented Jun 17, 2025

Not sure exactly what to do with the unit tests (yarn test --group=tabs --theme=base), as they seem to rely on the Lumo styling (some 20px magic number) and seem to completely fail on some getBoundingClientRect() call.

@jouni jouni requested a review from vursen June 17, 2025 13:22
@jouni jouni changed the title experiment: Tabs base styles experiment: add tabs base styles and visual tests Jun 18, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants