Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filipino Localization for the Philippines Holiday Class #2067

Closed
arkid15r opened this issue Oct 20, 2024 · 2 comments · Fixed by #2093
Closed

Add Filipino Localization for the Philippines Holiday Class #2067

arkid15r opened this issue Oct 20, 2024 · 2 comments · Fixed by #2093
Assignees

Comments

@arkid15r
Copy link
Collaborator

The vacanza/holidays package currently supports public holidays for the Philippines, as defined in the holidays/countries/philippines.py file. However, the package lacks Filipino translations for the holiday names. It seems we should use fil ISO 639-2 code as described here and here.

The holidays l10n documentation section -- https://holidays.readthedocs.io/en/latest/contributing.html#localization

Some l10n PR examples:

Personally I would prefer to see fil_PH as the default but en_PH would also work.

@code-leen we'd appreciate your help with this a lot!

@PPsyrius PPsyrius self-assigned this Oct 21, 2024
@PPsyrius
Copy link
Collaborator

PPsyrius commented Oct 29, 2024

@arkid15r I think it might be for the best to just use Tagalog (tl) instead of Filipino (fil) - as that's exactly what the ISO is using here https://www.iso.org/obp/ui/#iso:code:3166:PH

@arkid15r
Copy link
Collaborator Author

arkid15r commented Nov 1, 2024

Based on my research Philippines has 2 official languages : Filipino and English. Even though Filipino is Tagalog based language it's different (https://en.wikipedia.org/wiki/Filipino_language)

It is a standardized variety of the native language Tagalog,[3] spoken and written in Metro Manila, the National Capital Region, and in other urban centers of the archipelago.[4] The 1987 Constitution mandates that Filipino be further enriched and developed by the other languages of the Philippines.[5]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants