Add Thailand holidays localization: en_US, th

[PPsyrius]

Hi, this is based on the work on #827 and #929, which has since been merged into the beta branch, although I've yet to get the .mo and .po files generated by the script.

@arkid15r If you have any idea how to get this working somehow, let me know so I can fill in the translated localisations. :)

[KJhellico]

@arkid15r If you have any idea how to get this working somehow, let me know so I can fill in the translated localisations. :)

Try to run make l10n and you will have TH.pot (in holidays\locale\pot). Then you can make TH.po based on it, for en and th.

[PPsyrius]

I don't think that command worked for me, sadly @KJhellico

D:\[redacted]\python-holidays>make l10n
scripts/l10n/generate_po_files.py
Traceback (most recent call last):
  File "D:\[redacted]\python-holidays\scripts\l10n\generate_po_files.py", line 90, in <module>
    pot_generator.run()
  File "D:\[redacted]\python-holidays\scripts\l10n\generate_po_files.py", line 85, in run
    self.process_countries()
  File "D:\[redacted]\python-holidays\scripts\l10n\generate_po_files.py", line 43, in process_countries
    importlib.import_module(module), inspect.isclass
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.752.0_x64__qbz5n2kfra8p0\Lib\importlib\__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1206, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1142, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'holidays.countries.holidays\\countries\\albania'
make: *** [Makefile:28: l10n] Error 1

[KJhellico]

On Windows I could't do it too, so I did it on Linux :)

[PPsyrius]

I don't think I have much luck with make l10n on Windows 11's WSL mode either:

ppsyrius@[redacted]:/mnt/d/[redacted]/python-holidays$ make l10n
scripts/l10n/generate_po_files.py
Traceback (most recent call last):
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 90, in <module>
    pot_generator.run()
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 85, in run
    self.process_countries()
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 55, in process_countries
    subprocess.run(
  File "/usr/lib/python3.10/subprocess.py", line 501, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.10/subprocess.py", line 969, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1845, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'pot-create'
make: *** [Makefile:28: l10n] Error 1

The PYTHONPATH variable is already set here:

ppsyrius@[redacted]:/mnt/d/[redacted]/python-holidays$ echo $PYTHONPATH
/mnt/d/[redacted]/python-holidays

[KJhellico]

FileNotFoundError: [Errno 2] No such file or directory: 'pot-create'

pot-create is from lingua package. Did you run pip install --requirement requirements/dev.txt ?

[arkid15r]

I don't think I have much luck with make l10n on Windows 11's WSL mode either:

ppsyrius@[redacted]:/mnt/d/[redacted]/python-holidays$ make l10n
scripts/l10n/generate_po_files.py
Traceback (most recent call last):
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 90, in <module>
    pot_generator.run()
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 85, in run
    self.process_countries()
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 55, in process_countries
    subprocess.run(
  File "/usr/lib/python3.10/subprocess.py", line 501, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.10/subprocess.py", line 969, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1845, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'pot-create'
make: *** [Makefile:28: l10n] Error 1

The PYTHONPATH variable is already set here:

ppsyrius@[redacted]:/mnt/d/[redacted]/python-holidays$ echo $PYTHONPATH
/mnt/d/[redacted]/python-holidays

@PPsyrius
The errors you posted definitely indicate a lack of proper Windows support, sorry about that.
I'll try to figure out what can be done to improve it this week.

[arkid15r]

Thanks for your efforts to localize Thailand holidays.

It seems that your approach is a bit different from what we already have for other countries.
In general in a localized version I'd expect thailand.py to have holiday names in Thai (not English) language. Then .pot file is generated (make l10n) and added for each of languages you want to translate into. After the .po files are added and translated we can use .mo files (will done automatically).

The l10n support has just been added so there may be changes in the translation related code/processes.

[PPsyrius]

On the reason why I stick with en instead of th as default for Thailand's i18n implementation:

• We've already tested all the functions for en implementation, but the same could not be said for th at the moment; once I can confirm that the translation works out fine, a quick switch for them all shouldn't hopefully be too hard to implement.
• Due to how the Thai character works, we're likely need to use # noqa: E501 on most string declarations to suppress all the errors as Thai consonants and vowels are counted separately i.e. the HM King Bhumibol Adulyadej the Great's Birthday (48 chars long) would become วันคล้ายวันพระราชสมภพของพระบาทสมเด็จพระบรมชนกาธิเบศร มหาภูมิพลอดุลยเดชมหาราช (77 chars long). While this is one of the outlier examples, the point still stands.

Despite all the stated reasoning above, I don't mind switching the default ones to Thai as that would indeed help with standardization for the library as a whole.

[PPsyrius]

Did you run pip install --requirement requirements/dev.txt` ?

Yes, although I did have this warning for WSL

Defaulting to user installation because normal site-packages is not writeable

---

Edit: After reinstalling and using .venv, I still got struck at the exact location (sans the Defaulting to user installation), although after creating the \holidays\locale\pot manually, the code seems to be stuck here instead:

(.venv) ppsyrius@[redacted]:/mnt/d/[redacted]/python-holidays$ make l10n
scripts/l10n/generate_po_files.py
Traceback (most recent call last):
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 90, in <module>
    pot_generator.run()
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 85, in run
    self.process_countries()
  File "/mnt/d/[redacted]/python-holidays/scripts/l10n/generate_po_files.py", line 71, in process_countries
    subprocess.run(
  File "/usr/lib/python3.10/subprocess.py", line 501, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.10/subprocess.py", line 969, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1845, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'msgmerge'

[KJhellico]

FileNotFoundError: [Errno 2] No such file or directory: 'msgmerge'

On Linux (Debian, Ubuntu) msgmerge is part of gettext package. Try apt install gettext -y in WSL. (Maybe sudo apt install gettext -y - I don't know much about WSL)

[PPsyrius]

On Linux (Debian, Ubuntu) msgmerge is part of gettext package. Try apt install gettext -y in WSL. (Maybe sudo apt install gettext -y - I don't know much about WSL)

This and manually creating additional holidays\locale\TH\LC_MESSAGES folder seem to finally get the script running, thanks again for all the help :)

---

So to recap for Windows users (could be useful for others)

• Enable "Windows Subsystem for Linux" (WSL2)
  • wsl --install, select your repo of choice (I picked Ubuntu 22.04 LTS for this case)
  • After setting everything up, wsl ~ to enter WSL
• Installing additional packages:
  • sudo apt update && sudo apt upgrade -y to update Linux distro.
  • sudo apt install gettext -y needed for localisation.
• cd to the installed location: cd /mnt/[drive no]/[whatever folders]/python-holidays
• Check echo $PYTHONPATH; if this is not set yet, run export PYTHONPATH=/mnt/[drive no]/[whatever folders]/python-holidays
• Installing additional python requirements: pip install --requirement requirements/dev.txt
• Creating the following files and folders (either in Windows Explorer's GUI or mkdir in the command line):
  • holidays/locale/pot
  • holidays/locale/[new_language_code]/LC_MESSAGES/[new_language_code].po ← (if new translation files, both for the new languages and in English folder)
• You should now be able to run make l10n

[PPsyrius]

@arkid15r @KJhellico There seems to be some problems for non-ASCII msgid; it seems like defaulting to English may be a necessity here:

holidays/locale/pot/TH.pot:56: warning: The following msgid contains non-ASCII characters.
                                        This will cause problems to translators who use a character encoding
                                        different from yours. Consider using a pure ASCII msgid instead.
                                        Emergency Lockdown (Thai Military Coup d'état)

Same goes for using the Thai language as the default loc:

holidays/locale/pot/TH.pot:92: invalid multibyte sequence
holidays/locale/pot/TH.pot:92: invalid multibyte sequence

[coveralls]

Coverage: 100.0%. Remained the same when pulling a2c8638 on PPsyrius:thailand_i18n_support into b3254f0 on dr-prodigy:beta.

[mborsetti]

Hi @arkid15r,

I am thinking of contributing Italian names for Italian holidays and am following this thread closely. I too am on Windows but don't know the technology/library used here, and am a bit worried as I don't really want to install WSL2. Also worrisome is the lack of support for UTF-8 (based on the error reported above) as it's required for Italian.

As the author of #827 and the make file that doesn't seem to work on Windows, do you have any input on where I should look to be able to contribute a Windows-native solution?

[arkid15r]

• We've already tested all the functions for en implementation, but the same could not be said for th at the moment; once I can confirm that the translation works out fine, a quick switch for them all shouldn't hopefully be too hard to implement.

Well, that's how l10n works. We have it working/tested for en and want it localized for th (also working and tested).

• Due to how the Thai character works, we're likely need to use # noqa: E501 on most string declarations to suppress all the errors as Thai consonants and vowels are counted separately i.e. the HM King Bhumibol Adulyadej the Great's Birthday (48 chars long) would become วันคล้ายวันพระราชสมภพของพระบาทสมเด็จพระบรมชนกาธิเบศร มหาภูมิพลอดุลยเดชมหาราช (77 chars long). While this is one of the outlier examples, the point still stands.

There is a way to split long Python strings using "()". You can also suppress warnings on a per-file basis.

Despite all the stated reasoning above, I don't mind switching the default ones to Thai as that would indeed help with standardization for the library as a whole.

👍

[arkid15r]

holidays/locale/pot/TH.pot:56: warning: The following msgid contains non-ASCII characters.
                                        This will cause problems to translators who use a character encoding
                                        different from yours. Consider using a pure ASCII msgid instead.
                                        Emergency Lockdown (Thai Military Coup d'état)

It looks like a warning that can be ignored.

Same goes for using the Thai language as the default loc:

holidays/locale/pot/TH.pot:92: invalid multibyte sequence
holidays/locale/pot/TH.pot:92: invalid multibyte sequence

This one might be more serious but still can be fixable. The gettext l10n mechanism is widely used and tested.

[arkid15r]

Hi @arkid15r,

I am thinking of contributing Italian names for Italian holidays and am following this thread closely. I too am on Windows but don't know the technology/library used here, and am a bit worried as I don't really want to install WSL2. Also worrisome is the lack of support for UTF-8 (based on the error reported above) as it's required for Italian.

As the author of #827 and the make file that doesn't seem to work on Windows, do you have any input on where I should look to be able to contribute a Windows-native solution?

Hi @mborsetti, I've moved this to a separate issue

[arkid15r]

This l10n PR looks good!
Just a couple of minot suggestions:

[arkid15r]

🇹🇭 LGTM

[arkid15r]

Great l10n work!

Additionally, thank you for the Windows environment setup instructions!