Optimize Nigeria observed holidays #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Refactor HolidayBase class and utils
Add GitHub pull request template
Upgrade dependency: change black version from 22.12.0 to 23.1.0
Replace `relativedelta` with `timedelta` for days offset calculation
Refactor days offset calculation: replace `relativedelta` with `timedelta` (tests)
* TH: modify Thailand code to support i18n * TH: applying `KJhellico`'s suggestion, more accurate titles Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * TH: non-ASCII `msgid` fixed * TH: Thai translation localisations * TH: fixed mismatch file title Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> * TH: `set_locale` -> `set_language` * TH: switch default loc to `th` * TH: split string Co-authored-by: Arkadii Yakovets <ark@cho.red> * TH: adjust file description Co-authored-by: Arkadii Yakovets <ark@cho.red> * TH: adjust file description (2) Co-authored-by: Arkadii Yakovets <ark@cho.red> * TH: avoid explicit `# noqa: E501` usage * TH: improved national day trigger * TH: avoid explicit `# noqa: E501` for testcases --------- Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <ark@cho.red>
* IE: Fixed St. Brigit's Day (Monday is the day itself, not `(observed)`) Co-Authored-By: Kevin Gill <kevin@movieextras.ie> * IE: applying code suggestions Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com> * IE: add testcase for St. Brigid's Day * IE: [ ] --> ( ) Co-authored-by: Arkadii Yakovets <ark@cho.red> --------- Co-authored-by: Kevin Gill <kevin@movieextras.ie> Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <ark@cho.red>
* Fix Japan en_US translation * fix Co-authored-by: Arkadii Yakovets <ark@cho.red> --------- Co-authored-by: Arkadii Yakovets <ark@cho.red>
…lidays into KJhellico-upd-peru-loc
KJhellico
force-pushed
the
opt-nigeria-obs
branch
from
9d690a1 to
903efca
Compare
arkid15r
reviewed
Feb 24, 2023
KJhellico
force-pushed
the
opt-nigeria-obs
branch
from
903efca to
8f6d7c7
Compare
# Conflicts: # CHANGES # holidays/__init__.py # setup.cfg
KJhellico
force-pushed
the
opt-nigeria-obs
branch
from
8f6d7c7 to
30a6fbb
Compare
arkid15r
added a commit
that referenced
this pull request
Feb 27, 2023
arkid15r
pushed a commit
that referenced
this pull request
Feb 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.