Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize ascii incompatible countries #955

Merged
merged 11 commits into from
Feb 17, 2023

Conversation

arkid15r
Copy link
Collaborator

Add en_US localization for:

  • Armenia
  • Belarus
  • Bulgaria
  • Canada
  • Cyprus
  • Ethiopia
  • Georgia
  • Greece
  • Japan
  • Russia
  • Serbia

Update po generation files script. Update MANIFEST.in. Update README.rst. Fix packaging.

Add en_US localizatin for:
  - Armenia
  - Belarus
  - Bulgaria
  - Canada
  - Cyprus
  - Ethiopia
  - Georgia
  - Greece
  - Japan
  - Russia
  - Serbia
Update po generation files script.
Update MANIFEST.in.
Update README.rst.
Fix packaging.
@coveralls
Copy link

coveralls commented Feb 16, 2023

Coverage Status

Coverage: 100.0%. Remained the same when pulling 996bc62 on arkid15r:localize-ascii-incompatible-countries into d267936 on dr-prodigy:beta.

@PPsyrius
Copy link
Collaborator

PPsyrius commented Feb 17, 2023

A bit minor note: I did try switching to having Thai text as default based on this PR, and the issue still persists when using make l10n as you can see below:

holidays/locale/pot/TH.pot:53: warning: The following msgid contains non-ASCII characters.
                                        This will cause problems to translators who use a character encoding
                                        different from yours. Consider using a pure ASCII msgid instead.
                                        พระราชพิธีฉลองสิริราชสมบัติครบ 60 ปี .. 2549
holidays/locale/pot/TH.pot:53: invalid multibyte sequence
holidays/locale/pot/TH.pot:53: invalid multibyte sequence
holidays/locale/pot/TH.pot:53: invalid multibyte sequence
holidays/locale/pot/TH.pot:53: invalid multibyte sequence
holidays/locale/pot/TH.pot:53: invalid multibyte sequence
holidays/locale/pot/TH.pot:53: invalid multibyte sequence

With this in mind, I'm considering continuing my approach on #946 instead, but will switch around the test cases to generate our desired result of having th as default and en_US as supported.

@arkid15r arkid15r merged commit 77d87ed into vacanza:beta Feb 17, 2023
@arkid15r arkid15r deleted the localize-ascii-incompatible-countries branch February 17, 2023 18:38
This was referenced Feb 20, 2023
@arkid15r arkid15r added the l10n label Feb 22, 2023
@arkid15r arkid15r mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants