Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant #noqa E501 labels #1322

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

This PR eliminates the now redundant E501 PEP8 labels from recent #1297 changes whenever applicable, as well as a general refractor for Brunei Darussalam, Cambodia, and Thailand to better utilize the new limit. This PR also removes a zero-width space that got into 0.27 release somehow.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling ebfecf8 on PPsyrius:remove_redundant_E501 into ceefae5 on dr-prodigy:beta.

@arkid15r arkid15r changed the title Remove redundant #noqa e501 labels Remove redundant #noqa E501 labels Jun 21, 2023
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks fine 👍

Thank for reformatting these!

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Jun 21, 2023
@KJhellico KJhellico merged commit ed64ec3 into vacanza:beta Jun 22, 2023
@KJhellico KJhellico removed the ready for beta Ready to merge on beta branch label Jun 22, 2023
@KJhellico
Copy link
Collaborator

It has been merged into beta.

@PPsyrius PPsyrius deleted the remove_redundant_E501 branch June 23, 2023 02:42
@KJhellico KJhellico mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants