Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common::TestCase methods #1324

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Now assertHolidayName/assertNoHolidayName methods, if parameter is a sequence of dates, check for the presence/absence of these dates in holiday list, instead of checking for presence of holiday with the specified name on these dates.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@KJhellico KJhellico requested a review from arkid15r June 21, 2023 15:45
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 2b0cd76 on KJhellico:fix-tests-common into ceefae5 on dr-prodigy:beta.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

LGTM

@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Jun 21, 2023
@KJhellico KJhellico merged commit 6efb61d into vacanza:beta Jun 22, 2023
@KJhellico KJhellico deleted the fix-tests-common branch June 22, 2023 10:42
@KJhellico KJhellico removed the ready for beta Ready to merge on beta branch label Jun 22, 2023
@KJhellico KJhellico mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants