Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #1330

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Update PR template #1330

merged 1 commit into from
Jun 22, 2023

Conversation

arkid15r
Copy link
Collaborator

Rephrase dependency update change type.

Proposed change

Rephrase dependency update change type.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

Rephrase dependency update change type.
@arkid15r arkid15r requested a review from KJhellico June 22, 2023 15:47
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 135136b on arkid15r:update-pr-template into 3b22360 on dr-prodigy:beta.

@arkid15r arkid15r merged commit 6fe880c into vacanza:beta Jun 22, 2023
@arkid15r arkid15r deleted the update-pr-template branch June 22, 2023 16:16
@KJhellico KJhellico mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants