Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Finland holidays l10n #1883

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Update Finland holidays l10n #1883

merged 1 commit into from
Jul 27, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Update Finland holidays l10n:

  • change sv locale to sv_FI
  • update of some holidays Swedish translations

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@KJhellico KJhellico added the l10n label Jul 27, 2024
@KJhellico KJhellico requested a review from arkid15r as a code owner July 27, 2024 15:47
Copy link

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (98218f6) to head (351f2ba).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1883   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          184       184           
  Lines        11194     11194           
  Branches      1765      1765           
=========================================
  Hits         11194     11194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇫🇮 LGTM

@arkid15r arkid15r added this pull request to the merge queue Jul 27, 2024
Merged via the queue into vacanza:dev with commit fa3feb8 Jul 27, 2024
25 checks passed
@KJhellico KJhellico deleted the upd-finland branch July 27, 2024 19:56
@KJhellico KJhellico mentioned this pull request Aug 5, 2024
@arkid15r arkid15r mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants