-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add New Zealand Subdivision Aliases (EN
, MI
, HASC)
#1952
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1952 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 188 188
Lines 11419 11400 -19
Branches 1795 1785 -10
=========================================
- Hits 11419 11400 -19 ☔ View full report in Codecov by Sentry. |
This should hopefully be the last PR for " |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PPsyrius you've done a tremendous work migrating deprecated subdivisions to subdivisions aliases. Thank you!
I'm merging this as is for the next release so any other possible changes go in a separate PR(s).
Proposed change
Migrates deprecated New Zealand subdivisions to a new subdivision aliases system, and Maori names (ISO) and HASC 2-letter codes were added as optional aliases.
The "
South Canterbury
" subregion is undeprecated as they're still in active use as Regional Holiday Anniversaries: https://www.govt.nz/browse/work/public-holidays-and-work/public-holidays-and-anniversary-dates/ . As the New Zealand government never gave these territories any acronyms, the full name is getting used here. I'm not sure about its name, though; maybe a possible rename to "Canterbury (South)
" to match the source above?"
Waitangi
" is removed from the_deprecated_subdivisions
list altogether as they're mistakenly added there in the first place in #608. It isn't remapped into any other subdivision at the moment, so they should be safe to remove here.Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally