-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated fix-encoding-pragma
, add pyupgrade
#2007
Remove deprecated fix-encoding-pragma
, add pyupgrade
#2007
Conversation
It's great update! But we also need to fix tests/test_i10n.py. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff, thanks @PPsyrius !
fix-encoding-pragma
, migrates to pyupgrade
fix-encoding-pragma
, add pyupgrade
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2007 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 188 188
Lines 11409 11409
Branches 1791 1791
=========================================
Hits 11409 11409 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Proposed change
This PR switches out
fix-encoding-pragma
hook forpyupgrade
.I noticed that the
fix-encoding-pragma
used inmake pre-commit
is listed as deprecated, as seen here:As written in
pre-commit-hooks
pypl page:Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally