Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to holidays from python-holidays #2027

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

arkid15r
Copy link
Collaborator

Make it consistent for GitHub, PyPI, and Read the Docs

Proposed change

Prepare changes for the following naming standardization.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Make it consistent for GitHub, PyPI, and Read the Docs
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ab5816a) to head (c9316d5).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2027   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines        11522     11522           
  Branches      1798      1798           
=========================================
  Hits         11522     11522           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico previously approved these changes Sep 29, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PPsyrius
PPsyrius previously approved these changes Sep 30, 2024
@PPsyrius
Copy link
Collaborator

LGTM 🌐

@arkid15r arkid15r dismissed stale reviews from PPsyrius and KJhellico via 573d220 October 3, 2024 18:04
@arkid15r arkid15r requested review from KJhellico and PPsyrius October 7, 2024 16:09
Copy link

sonarqubecloud bot commented Oct 7, 2024

@arkid15r arkid15r enabled auto-merge October 7, 2024 16:29
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r added this pull request to the merge queue Oct 7, 2024
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume you got all the files, LGTM 🌐

Merged via the queue into vacanza:dev with commit 1f3170f Oct 7, 2024
32 checks passed
@arkid15r arkid15r deleted the move-to-holidays branch October 7, 2024 16:42
@arkid15r
Copy link
Collaborator Author

arkid15r commented Oct 7, 2024

I'm going to assume you got all the files, LGTM 🌐

Hopefully 🤞

If you notice something you know what to do :)

@arkid15r arkid15r mentioned this pull request Oct 7, 2024
@PPsyrius
Copy link
Collaborator

@arkid15r I think we might've forgotten to update codecov after we implemented the repo name change.

@arkid15r
Copy link
Collaborator Author

@arkid15r I think we might've forgotten to update codecov after we implemented the repo name change.

It looks like it's okay now. Let's monitor it for a bit more.

mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants