-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to holidays
from python-holidays
#2027
Conversation
Make it consistent for GitHub, PyPI, and Read the Docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2027 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 190 190
Lines 11522 11522
Branches 1798 1798
=========================================
Hits 11522 11522 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM 🌐 |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to assume you got all the files, LGTM 🌐
Hopefully 🤞 If you notice something you know what to do :) |
@arkid15r I think we might've forgotten to update codecov after we implemented the repo name change. |
It looks like it's okay now. Let's monitor it for a bit more. |
Make it consistent for GitHub, PyPI, and Read the Docs
Proposed change
Prepare changes for the following naming standardization.
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally