-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Vietnam holidays #2049
Update Vietnam holidays #2049
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2049 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 190 190
Lines 11522 11537 +15
Branches 1798 1743 -55
=========================================
+ Hits 11522 11537 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🇻🇳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Proposed change
Update Vietnam holidays:
Type of change
holidays
functionality in general)Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally