Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor v1 incompatibility warning #2100

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Nov 1, 2024

Proposed change

Refactor v1 future incompatibility warning based on the users concerns (1, 2)

The changes summary:

  • add version.py as a new version value location
  • move the warning to deprecations directory
  • update the release documentation

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  - add version.py as a new version value location
  - move the warning to `deprecations` directory
  - update documentation
  - update related scripts
@github-actions github-actions bot added the v1 label Nov 1, 2024
@arkid15r arkid15r changed the title Refactor v1 warning Refactor v1 incompatibility warning Nov 1, 2024
@arkid15r arkid15r marked this pull request as draft November 1, 2024 18:07
Copy link

sonarcloud bot commented Nov 1, 2024

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e61c6ed) to head (f6b740a).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2100   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       192    +1     
  Lines        11549     11551    +2     
  Branches      1736      1736           
=========================================
+ Hits         11549     11551    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkid15r arkid15r marked this pull request as ready for review November 1, 2024 18:21
@arkid15r arkid15r removed the v1 label Nov 1, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Nov 2, 2024
Merged via the queue into vacanza:dev with commit fbcec7b Nov 2, 2024
29 checks passed
@arkid15r arkid15r deleted the refactor-v1-warning branch November 2, 2024 00:52
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants