Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add financial markets l10n support #2116

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

KJhellico
Copy link
Collaborator

Proposed change

Add financial markets l10n support to generate_po_files.py script.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

sonarqubecloud bot commented Nov 8, 2024

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1baee5f) to head (63077b2).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        11591     11591           
  Branches      1747      1747           
=========================================
  Hits         11591     11591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KJhellico KJhellico mentioned this pull request Nov 8, 2024
9 tasks
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💹

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending i18n to markets too!

Just a side note -- we now have both countries and markets .po files in the same locations. Not sure if it's possible to structure them better.

@arkid15r arkid15r added this pull request to the merge queue Nov 8, 2024
Merged via the queue into vacanza:dev with commit b85c134 Nov 8, 2024
29 checks passed
@KJhellico KJhellico deleted the add-markets-l10n-support branch November 8, 2024 19:06
@KJhellico KJhellico mentioned this pull request Nov 18, 2024
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants