-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add financial markets l10n support #2116
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 192 192
Lines 11591 11591
Branches 1747 1747
=========================================
Hits 11591 11591 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for extending i18n to markets too!
Just a side note -- we now have both countries and markets .po files in the same locations. Not sure if it's possible to structure them better.
Proposed change
Add financial markets l10n support to
generate_po_files.py
script.Type of change
holidays
functionality in general)Checklist
make check
, all checks and tests are green