Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Timor Leste holidays: Add 2024 Nov 29 Special Holiday #2150

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Nov 28, 2024

Proposed change

Add an additional day off on 29 November, 2024 for Timor Leste on the occasion of the 49th Anniversary of the Proclamation of Independence of Timor-Leste

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2922431) to head (332ae06).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          194       194           
  Lines        11716     11716           
  Branches      1771      1771           
=========================================
  Hits         11716     11716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Nov 28, 2024
Merged via the queue into vacanza:dev with commit 3d2e28a Nov 28, 2024
28 checks passed
@PPsyrius PPsyrius deleted the tl_2024nov29 branch November 28, 2024 05:04
@arkid15r arkid15r mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants