Update Thailand holidays: extend support year down to 1914 #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2166 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 194 194
Lines 11541 11657 +116
Branches 1641 1691 +50
==========================================
+ Hits 11541 11657 +116 ☔ View full report in Codecov by Sentry. |
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
|
arkid15r
reviewed
Dec 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Extend Thailand holiday support from 1941 to 1914 (The First Public Holidays Act) based on the Royal Gazette (ราชกิจจานุเบกษา) records.
Note
A few key documents are still missing from the internet ever since the Secretariat of the Cabinet (สำนักเลขาธิการคณะรัฐมนตรี) revamped their website and accidentally rendered files older than the last 10 years which isn't included in the Royal Gazette inaccessible, for example:
Once that is fixed, I'll try to get another PR up to get this the final update it needs for any historical date pre-2000.
Another issue is the manual assignment of weekend dates outside of weekdays for Buddhist Sabbath days (วันพระ) which instead relies on the Thai LuniSolar calendar (not that this is required, the whole scheme was thankfully abandoned before the first in-lieu implementation was decreed for Thai holidays in 1961).
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green