Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Afghanistan holidays #2221

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Update Afghanistan holidays #2221

merged 2 commits into from
Jan 11, 2025

Conversation

KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Jan 10, 2025

Proposed change

Update Afghanistan holidays:

  • change Nowruz date to Solar Hijri Calendar
  • add Islamic Emirate Victory Day
  • add Islamic holidays exact dates
  • update some holidays validity intervals

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (683aedf) to head (56a5b50).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2221   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       196           
  Lines        11828     11839   +11     
  Branches      1707      1708    +1     
=========================================
+ Hits         11828     11839   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r enabled auto-merge January 10, 2025 17:25
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇦🇫

@arkid15r arkid15r added this pull request to the merge queue Jan 11, 2025
Merged via the queue into vacanza:dev with commit f010d0c Jan 11, 2025
32 checks passed
@KJhellico KJhellico deleted the upd-afghanistan branch January 12, 2025 08:06
@KJhellico KJhellico mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants