GH action CI/CD integration - #404 (massive thx+kudos to s-weigand) #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E203 needs to be ignore due to a false positive alert for slicing. See. PyCQA/pycodestyle#373 (comment)
and some minor fixes
for python runtime dependencies and used github-actions
quoting the addopts made them not being recognized properly
for future commits
This should catch all changes on beta which were missing. I left changes which were added in the cleanup of 'unstable' e.g. 'holidays.utils.is_leap_year' 'test/countries/test_saudiarabia.py' was renamed to 'test/countries/test_saudi_arabia.py' to be consistent with 'holidays/countries/saudi_arabia.py'
Pull Request Test Coverage Report for Build 597635619
💛 - Coveralls |
dr-prodigy
added a commit
that referenced
this pull request
Feb 24, 2021
(massive thx+kudos to s-weigand) * added coverage.xml to .gitignore * Basic rewrite of the travis tests, with github actions * removed now obsolete travis config * Added bump2version and its config * moved flake8 config to setup.cfg * Formatted requirements with comments * Created test file for each country and moved corresponding tests there * Added pre-commit and a basic config containing black+its config * Added flake8 to pre-commit config and set flake8 to ignore E203 E203 needs to be ignore due to a false positive alert for slicing. See. PyCQA/pycodestyle#373 (comment) * Replaced flake8 tests with pre-commit ones, since flake8 is included * Updated workflow to use tests folder, upload coverage to coveralls.io and some minor fixes * Added pre-commit hook that adds encoding shebang to all files py27 compat * Added coverage config * Added tox+pytest config and added .tox to .gitignore * Added rst checking tools to pre-commit and fixed rst issues * Added workflow dispatch as an option to run the workflow * Removed py35 as was done in https://github.com/dr-prodigy/python-holidays/pull/402 * Added dependabot config to receive automatics update PR's for python runtime dependencies and used github-actions * Fixed pytest config quoting the addopts made them not being recognized properly * Replaced travis with github actions badge * Changed contributing guide to reflect changed tooling * Formatted setup.py again with black * Auto-format, Israel to_jd_gregorianyear fix * requirements_dev.txt review, Israel fixes, CHANGES+README.rst reviews * precommit tasks run * removed python 2.7 checks from github CI/CD scripts * flake8 config fixes * travis build toml dependency fix * removed duplicated flake8 tests from coverage config * old tests.py using new test classes * tests tree reviewed * tests cleanup (warn: coverage report -m needs fixing) * Fixed usage of coveralls with gh-action after 3.0.0 release * more recent tests re-applied - #404 * copyright 2021 * test tree refactoring, pytest running thru tests.py * Flake8 test removed, pyproject.toml cleanup * Added .gitaddtributes file to ensure consistent '\n' line ending for future commits * Added pre-commit hook to enforce '\n' lineending and applied it on all files * Copied files from 'holiday' and 'tests' over and ran 'pre-commit run -a' This should catch all changes on beta which were missing. I left changes which were added in the cleanup of 'unstable' e.g. 'holidays.utils.is_leap_year' 'test/countries/test_saudiarabia.py' was renamed to 'test/countries/test_saudi_arabia.py' to be consistent with 'holidays/countries/saudi_arabia.py' * is_leap_year removal Co-authored-by: s-weigand <s.weigand.phy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.