Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jamaica holidays #913

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Update Jamaica holidays #913

merged 2 commits into from
Feb 3, 2023

Conversation

KJhellico
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jan 28, 2023 •
edited
Loading

Coverage Status

Coverage: 100.0%. Remained the same when pulling c1674f6 on KJhellico:upd-jamaica into f8edd7b on dr-prodigy:beta.

arkid15r
arkid15r reviewed Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add https://www.mlss.gov.jm/wp-content/uploads/2017/11/The-Holidays-Public-General-Act.pdf to the referece section ?

LGTM

holidays/countries/jamaica.py Outdated Show resolved Hide resolved
@KJhellico @arkid15r
fix
c1674f6 
Co-authored-by: Arkadii Yakovets <ark@cho.red>
@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Feb 3, 2023
@arkid15r arkid15r changed the title Jamaica holidays update Update Jamaica holidays Feb 3, 2023
@arkid15r arkid15r merged commit 43116b1 into vacanza:beta Feb 3, 2023
@arkid15r arkid15r removed the ready for beta Ready to merge on beta branch label Feb 3, 2023
@arkid15r
Copy link
Collaborator

arkid15r commented Feb 3, 2023

Great work 👍, thank you!

@KJhellico KJhellico deleted the upd-jamaica branch February 3, 2023 18:35
This was referenced Feb 20, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KJhellico @coveralls @arkid15r