Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Thailand holidays #929

Merged
merged 57 commits into from
Feb 10, 2023
Merged

Improve Thailand holidays #929

Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
7655c6e
Merge pull request #915 from dr-prodigy/beta
arkid15r Jan 30, 2023
cb71848
Thai Lunar Calendar added, exact start of holidays for historic use, …
PPsyrius Feb 4, 2023
db48d5e
In-code comment improvements for readability
PPsyrius Feb 4, 2023
b36704b
Add contact info in case future changes are needed
PPsyrius Feb 4, 2023
9a764a9
Fixed syntax error
PPsyrius Feb 4, 2023
c96309f
TH Special Holidays code improvements
PPsyrius Feb 4, 2023
3443182
TH in lieu holiday trigger refactor
PPsyrius Feb 4, 2023
f2e2902
TH: turns out <= <= is now a thing
PPsyrius Feb 4, 2023
58f4a41
TH testcases updated
PPsyrius Feb 4, 2023
88a35c6
TH: case switch for standardizaton
PPsyrius Feb 4, 2023
6e4d4fd
Merge branch 'beta' into thailand_improved
PPsyrius Feb 4, 2023
f68e1ca
TH autoformatting from running `tox`
PPsyrius Feb 4, 2023
4027ef6
TH: E266 comment block format adherence
PPsyrius Feb 5, 2023
61e315b
TH: E501 line too long format adherence (except link and Thai date na…
PPsyrius Feb 5, 2023
81a7477
TH: E501 cleanups. other final checks (for now)
PPsyrius Feb 5, 2023
db4cda7
TH Sort testcase date
PPsyrius Feb 5, 2023
7842122
Added tests for Thailand
KJhellico Feb 5, 2023
7fb9721
Merge pull request #2 from KJhellico/thailand_improved
PPsyrius Feb 5, 2023
2a13149
TH fixed Visakha Bucha trigger
PPsyrius Feb 5, 2023
7c5a1ac
TH fixed wording, add missing special election holiday
PPsyrius Feb 5, 2023
7efb49a
TH fixes New Year's Eve (in lieu)
PPsyrius Feb 6, 2023
aa34b76
TH Songkran special in lieu, fixes Queen Sirikit's bday error
PPsyrius Feb 6, 2023
4e07d1c
TH Asarnha-Buddhist Lent Day in lieu fixes
PPsyrius Feb 6, 2023
3bcc8e5
TH: holiday limiter is ; not , (1)
PPsyrius Feb 6, 2023
b501629
TH: holiday limiter is ; not , (2)
PPsyrius Feb 6, 2023
37180b5
TH: remove redundant function (1)
PPsyrius Feb 6, 2023
38a7fd0
TH: remove redundant function (2)
PPsyrius Feb 6, 2023
bb03c9c
TH: remove redundant function (3)
PPsyrius Feb 6, 2023
ef7275c
TH: remove redundant function (4)
PPsyrius Feb 6, 2023
fe52dbf
TH: remove useless recursive call for `add_holiday`
PPsyrius Feb 6, 2023
9676e4c
TH: improve test code
PPsyrius Feb 6, 2023
ee97c5a
TH: remove redundant function (5)
PPsyrius Feb 6, 2023
0f78df0
TH: add missing `self.observed`, remove all defunct codes
PPsyrius Feb 6, 2023
3206716
TH: further simplify Asarnha Bucha trigger
PPsyrius Feb 6, 2023
7964a33
TH: improve test code (2)
PPsyrius Feb 6, 2023
87e73cf
TH: no `self.observed` needed if they already have special in-lieus
PPsyrius Feb 7, 2023
13bacc4
TH: adjust this for coverall tests
PPsyrius Feb 7, 2023
47f6dc2
TH: Thai lunar calendar now works up to 1941, all trigger now starts …
PPsyrius Feb 7, 2023
b7793e1
TH: test case refractor + extend checks to 2030
PPsyrius Feb 7, 2023
aa0a822
TH: Buddhist holiday extended testcases, applying suggestions
PPsyrius Feb 7, 2023
fc54e87
Tests update
KJhellico Feb 7, 2023
3f23a8b
Merge pull request #3 from KJhellico/thailand_improved
PPsyrius Feb 7, 2023
1e97e26
TH: remove `_en` suffix, `__init__(self, **kwargs):`
PPsyrius Feb 9, 2023
93a775f
TH: code improvements suggestions from @arkid15r
PPsyrius Feb 9, 2023
3707ed5
TH: remove financial holiday stubs (this will be its own thing later)
PPsyrius Feb 9, 2023
9ae01db
TH: move sources to 2nd row, `_ThaiLuniSolar` is now in util.py
PPsyrius Feb 9, 2023
b8686d4
TH: add Atthami Bucha and Ok Phansa support for
PPsyrius Feb 9, 2023
388a690
TH: fixed double `raeknakhwan` oversight
PPsyrius Feb 9, 2023
a48c80e
TH: `_ThaiLuniSolar` either returns date-type or None
PPsyrius Feb 9, 2023
5235050
TH: `add_holiday` --> `_add_with_observed` for unified wording
PPsyrius Feb 9, 2023
8126bd2
TH: `KJhellico`'s suggestions
PPsyrius Feb 9, 2023
2441e34
TH: applying `arkid15r` 's suggestions
PPsyrius Feb 10, 2023
6990cd8
TH: in-line single instance holidays
PPsyrius Feb 10, 2023
a443bc4
TH: forgot to re-sort this, oof
PPsyrius Feb 10, 2023
372f631
TH: fixed duplicate var, other improvements
PPsyrius Feb 10, 2023
c0902d7
TH: clean up comments
PPsyrius Feb 10, 2023
4072208
TH: back to `@lru_cache()` again
PPsyrius Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading