Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apostrophes: change to ' #2016

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

arkid15r
Copy link
Collaborator

Proposed change

Update apostrophes: change to '

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6b1060b) to head (5e4ab74).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2016   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          189       189           
  Lines        11457     11457           
  Branches      1794      1794           
=========================================
  Hits         11457     11457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/source/conf.py Outdated Show resolved Hide resolved
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
KJhellico
KJhellico previously approved these changes Sep 25, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

sonarcloud bot commented Sep 25, 2024

@arkid15r arkid15r added this pull request to the merge queue Sep 25, 2024
Merged via the queue into vacanza:dev with commit 0e58e46 Sep 25, 2024
32 checks passed
@arkid15r arkid15r deleted the update-apostrophes branch September 25, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants