avoid sending empty Iwant messages

vacp2p · Apr 27, 2021 · 77158bb · 77158bb
1 parent 06701f4
commit 77158bb
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/libp2p/protocols/pubsub/gossipsub.nim b/libp2p/protocols/pubsub/gossipsub.nim
@@ -247,7 +247,9 @@ proc handleControl(g: GossipSub, peer: PubSubPeer, rpcMsg: RPCMsg) =
     g.handlePrune(peer, control.prune)
 
     var respControl: ControlMessage
-    respControl.iwant.add(g.handleIHave(peer, control.ihave))
+    let iwant = g.handleIHave(peer, control.ihave)
+    if iwant.messageIDs.len > 0:
+      respControl.iwant.add(iwant)
     respControl.prune.add(g.handleGraft(peer, control.graft))
     let messages = g.handleIWant(peer, control.iwant)