Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt idontwant #1090

Merged
merged 1 commit into from
May 2, 2024
Merged

salt idontwant #1090

merged 1 commit into from
May 2, 2024

Conversation

arnetheduck
Copy link
Contributor

Salting idontwant ensures the message id does not exceed reasonable length and prevents the hash table itself from being attacked while at the same time bounding memory consumption.

@arnetheduck
salt idontwant
e567312 
Salting `idontwant` ensures the message id does not exceed reasonable
length and prevents the hash table itself from being attacked while at
the same time bounding memory consumption.
kaiserd
kaiserd approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. LGTM.

Salt function definition for context:

nim-libp2p/libp2p/protocols/pubsub/floodsub.nim

Line 45 in 02c96fc

proc salt*(f: FloodSub, msgId: MessageId): SaltedId =

@arnetheduck arnetheduck merged commit aef44ed into master May 2, 2024
8 of 9 checks passed
@arnetheduck arnetheduck deleted the salt-idontwant branch May 2, 2024 10:18
@ppopth ppopth mentioned this pull request May 3, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiserd kaiserd kaiserd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
nim-libp2p
Status: done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnetheduck @kaiserd