Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix devel compilation issues #1195

Merged
merged 5 commits into from
Sep 19, 2024
Merged

chore: fix devel compilation issues #1195

merged 5 commits into from
Sep 19, 2024

Conversation

diegomrsantos
Copy link
Contributor

@diegomrsantos diegomrsantos commented Sep 18, 2024

The main fixes relate to Nim 2.2 being more strict and not accepting calls with a wrong number of type parameters.

@diegomrsantos diegomrsantos changed the title fix safeConvert chore: fix devel compilation issues Sep 18, 2024
@diegomrsantos diegomrsantos marked this pull request as ready for review September 18, 2024 15:51
Copy link
Contributor

@lchenut lchenut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@diegomrsantos diegomrsantos added this pull request to the merge queue Sep 19, 2024
Merged via the queue into master with commit 68306cf Sep 19, 2024
14 checks passed
@diegomrsantos diegomrsantos deleted the fix-nim-2-2-devel branch September 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

libp2p/crypto/minasn1.nim doesn't build on Nim version-2-2/devel
2 participants