Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add arm64 for macOS #1212

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

chore(ci): add arm64 for macOS #1212

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b525cd3
add arm64 for macOS
diegomrsantos Oct 10, 2024
82086cc
try to update go version
diegomrsantos Oct 10, 2024
db8deaa
rename os
diegomrsantos Oct 10, 2024
0805e6e
add cpu to deps cache key
diegomrsantos Oct 10, 2024
14ec48e
add builder to deps cache key
diegomrsantos Oct 10, 2024
759f73c
Merge branch 'master' into ci-arm64
diegomrsantos Oct 10, 2024
aa3a75c
update comments
diegomrsantos Oct 10, 2024
665e652
Update .github/workflows/ci.yml
diegomrsantos Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/install_nim/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ runs:
run: |
if [[ '${{ inputs.cpu }}' == 'amd64' ]]; then
PLATFORM=x64
elif [[ '${{ inputs.cpu }}' == 'arm64' ]]; then
PLATFORM=arm64
else
PLATFORM=x86
fi
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ jobs:
cpu: amd64
- os: macos
cpu: amd64
- os: macos-14
cpu: arm64
- os: windows
cpu: amd64
nim:
Expand All @@ -47,6 +49,10 @@ jobs:
os: macos
builder: macos-13
shell: bash
- platform:
os: macos-14
builder: macos-14
shell: bash
- platform:
os: windows
builder: windows-2022
Expand Down Expand Up @@ -75,7 +81,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '~1.15.5'
go-version: '~1.16.0' # That's the minimum Go version that works with arm.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the README accordingly so this gets reflected? That is, that we support 1.16.0 onwards.


- name: Install p2pd
run: |
Expand All @@ -87,8 +93,8 @@ jobs:
with:
path: nimbledeps
# Using nim.branch as a simple way to differentiate between nimble using the "pkgs" or "pkgs2" directories.
# The change happened on Nimble v0.14.0.
key: nimbledeps-${{ matrix.nim.branch }}-${{ hashFiles('.pinned') }} # hashFiles returns a different value on windows
# The change happened on Nimble v0.14.0. ALso forcing the deps to be reinstalled on each os abd cpu.
diegomrsantos marked this conversation as resolved.
Show resolved Hide resolved
key: nimbledeps-${{ matrix.nim.branch }}-${{ matrix.builder }}-${{ matrix.platform.cpu }}-${{ hashFiles('.pinned') }} # hashFiles returns a different value on windows

- name: Install deps
if: ${{ steps.deps-cache.outputs.cache-hit != 'true' }}
Expand Down
Loading