chore: specify raising exceptions in daemon module
#1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladopajic
changed the title
daemon packagedaemon module
auto-merge was automatically disabled
February 13, 2025 14:46
Pull request was converted to draft
vladopajic
force-pushed
the
raising-daemon
branch
from
72702cd to
ad9b865
Compare
vladopajic
commented
Feb 13, 2025
| api: DaemonAPI, ticket: PubsubTicket | ||
| ) {. | ||
| async: ( | ||
| raises: [TransportIncompleteError, TransportError, CancelledError, CatchableError] |
There was a problem hiding this comment.
CatchableError has to be listed here because ticket.handler raises it.
richard-ramos
approved these changes
Feb 14, 2025
| @@ -903,9 +965,9 @@ proc openStream*( | |||
| stream.flags.incl(Outbound) | |||
| stream.transp = transp | |||
| result = stream | |||
| except CatchableError as exc: | |||
| except ResultError[ProtoError]: | |||
There was a problem hiding this comment.
TIL about this type of errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CatchableErrorin this PR where listed becauseP2PStreamCallbackhad it listed before in #1233 effort.part of #962 effort.