Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: list raised exceptions in switch services #1251

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

vladopajic
Copy link
Member

@vladopajic vladopajic commented Feb 12, 2025

this PR adds raising exceptions to switch service methods setup, run and stop.

part of #962 effort.

@vladopajic vladopajic marked this pull request as draft February 12, 2025 20:37
@vladopajic vladopajic changed the title chore: add raising exceptions to services chore: add raising exceptions to switch services Feb 13, 2025
@vladopajic vladopajic marked this pull request as ready for review February 13, 2025 10:33
@vladopajic vladopajic changed the title chore: add raising exceptions to switch services chore: list raised exceptions in switch services Feb 13, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.57143% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.57%. Comparing base (5d382b6) to head (5a72a86).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
libp2p/services/hpservice.nim 66.66% 5 Missing ⚠️
libp2p/services/wildcardresolverservice.nim 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
+ Coverage   84.54%   84.57%   +0.02%     
==========================================
  Files          93       93              
  Lines       16801    16827      +26     
==========================================
+ Hits        14205    14232      +27     
+ Misses       2596     2595       -1     
Files with missing lines Coverage Δ
libp2p/peerinfo.nim 68.51% <100.00%> (ø)
libp2p/protocols/connectivity/autonat/service.nim 96.71% <100.00%> (+2.22%) ⬆️
libp2p/services/autorelayservice.nim 97.32% <100.00%> (+2.17%) ⬆️
libp2p/switch.nim 90.95% <100.00%> (-0.58%) ⬇️
libp2p/services/wildcardresolverservice.nim 82.75% <50.00%> (-1.03%) ⬇️
libp2p/services/hpservice.nim 83.33% <66.66%> (-3.34%) ⬇️

... and 2 files with indirect coverage changes

Copy link

Commits must follow the Conventional Commits specification
Please fix these commit messages:


Co-authored-by: richΛrd <info@richardramos.me>
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
cc-ing: @arnetheduck for additional insights about this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants