Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transports): list raised exceptions #1255

Merged
merged 6 commits into from
Feb 24, 2025
Merged

Conversation

vladopajic
Copy link
Member

@vladopajic vladopajic commented Feb 14, 2025

this PR lists raised exceptions to transports's start and stop methods.

part of #962 effort.

@vladopajic vladopajic marked this pull request as draft February 14, 2025 12:30

proc impl(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what was the reason for having the logic within an impl proc. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure as well...

@vladopajic vladopajic changed the title chore: list raised exceptions in transports module chore(transports): list raised exceptions Feb 14, 2025
@vladopajic vladopajic marked this pull request as ready for review February 14, 2025 14:43
@vladopajic vladopajic merged commit a7ec485 into master Feb 24, 2025
17 checks passed
@vladopajic vladopajic deleted the raises-transports branch February 24, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants