Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(protocol): list raised exceptions #1260

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

chore(protocol): list raised exceptions #1260

wants to merge 17 commits into from

Conversation

vladopajic
Copy link
Member

@vladopajic vladopajic commented Feb 18, 2025 •
edited
Loading

this pr specifies raised exceptions in LPProtoHandler and all implementations.

CancelledErrors in handlers have been handled by adding trace message and connection is finally closed.

part of #962 effort.

hits for review: probably the best order of review would be to go through files following directory structure:

  • libp2p/protocols (first root files, then sub-directories)
  • examples (since there are just few of those)
  • and lastly tests

@vladopajic vladopajic marked this pull request as draft February 18, 2025 19:13
@vladopajic vladopajic changed the title wip: chore(protocol): list raised exceptions [WIP] chore(protocol): list raised exceptions Feb 18, 2025
@vladopajic vladopajic mentioned this pull request Feb 18, 2025
Closed
@vladopajic vladopajic changed the title [WIP] chore(protocol): list raised exceptions chore(protocol): list raised exceptions Feb 18, 2025
@vladopajic vladopajic marked this pull request as ready for review February 18, 2025 22:28
richard-ramos
richard-ramos approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@richard-ramos richard-ramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@vladopajic vladopajic enabled auto-merge (squash) February 24, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-ramos richard-ramos richard-ramos approved these changes

@arnetheduck arnetheduck Awaiting requested review from arnetheduck

At least 1 approving review is required to merge this pull request.

Assignees

@vladopajic vladopajic

Labels
None yet
Projects
nim-libp2p
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladopajic @richard-ramos