QUIC transport #563
Closed
QUIC transport #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markspanbroek
force-pushed
the
quic-transport
branch
from
a342cd9 to
ecfc5cf
Compare
dryajov
force-pushed
the
unstable
branch
2 times, most recently
from
39645a8 to
5419784
Compare
markspanbroek
force-pushed
the
quic-transport
branch
from
214f0ba to
1294f0a
Compare
Codecov Report
@@ Coverage Diff @@
## unstable #563 +/- ##
===========================================
Coverage ? 81.56%
===========================================
Files ? 59
Lines ? 11337
Branches ? 0
===========================================
Hits ? 9247
Misses ? 2090
Partials ? 0
|
markspanbroek
force-pushed
the
quic-transport
branch
from
1294f0a to
bed2827
Compare
markspanbroek
force-pushed
the
quic-transport
branch
from
21cb978 to
c4f2cae
Compare
markspanbroek
force-pushed
the
quic-transport
branch
2 times, most recently
from
c59c85c to
def2c21
Compare
|
Just changed to base branch to transport-session, should update automatically when we merge 565, and easier to review here |
markspanbroek
force-pushed
the
quic-transport
branch
from
def2c21 to
f0ad5f3
Compare
markspanbroek
force-pushed
the
transport-session
branch
from
1cbbcdd to
44bb234
Compare
markspanbroek
force-pushed
the
quic-transport
branch
from
f0ad5f3 to
bdbbc39
Compare
markspanbroek
force-pushed
the
transport-session
branch
from
44bb234 to
9d23e09
Compare
markspanbroek
force-pushed
the
quic-transport
branch
from
bdbbc39 to
8a1f4cc
Compare
# Conflicts: # libp2p/wire.nim # tests/testnative.nim
This error was raised when running nativetests. More info: nim-lang/Nim#8500
- accept upgrade manager in constructor - check that transport is running before calling stop - write empty message to ensure that quic stream is opened
QUIC support is currently unsafe and should only be used for testing.
In Windows, closing of QUIC connections often takes about 10 seconds.
markspanbroek
force-pushed
the
transport-session
branch
from
9d23e09 to
0c5b832
Compare
markspanbroek
force-pushed
the
quic-transport
branch
from
5cef807 to
c555d8c
Compare
6 tasks
|
Closed in favor of #725 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
…y) (#725) Our quic effort is blocked by bearssl not supporting TLS1.3, but since Mark did most of the work to implement Quic here: #563 and on nim-quic, this PR is going to bring encryption-less Quic into nim-libp2p This allows us to test it, and make sure it doesn't bitrot. Heavily WiP: - [X] Extract code from #563 - [X] Create custom muxer & upgrader - [X] Basic E2E switch test working - [x] Update nim-quic to get address informations in libp2p (for `observed address` and port 0 resolving) - [ ] More tests - [ ] Cleanup Since encryption is not yet supported, we're not compatible with any other libp2ps, and have to rely on home made protocols to retrieve the peer's id --------- Co-authored-by: markspanbroek <mark@spanbroek.net> Co-authored-by: Diego <diego@status.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Adds support for QUIC as a base transport for libp2p connections. Based on the nim-quic library.