Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Feature/waku v2 historical sketch #165

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Conversation

oskarth
Copy link
Contributor

@oskarth oskarth commented Jul 24, 2020

Addresses #164

@oskarth
Copy link
Contributor Author

oskarth commented Jul 25, 2020

Ping @decanus @kdeme

@oskarth
Copy link
Contributor Author

oskarth commented Jul 25, 2020

Also this spell check is annoying af

@oskarth oskarth force-pushed the feature/waku-v2-historical-sketch branch from 1821fc2 to f8d9e3c Compare July 27, 2020 02:13
@oskarth
Copy link
Contributor Author

oskarth commented Jul 27, 2020

Same as #163 comments @decanus

@oskarth oskarth requested a review from decanus July 27, 2020 02:14
@oskarth
Copy link
Contributor Author

oskarth commented Jul 28, 2020

@decanus can you please review/approve this.

decanus
decanus previously approved these changes Jul 28, 2020
Co-authored-by: Dean Eigenmann <7621705+decanus@users.noreply.github.com>
decanus
decanus previously approved these changes Jul 28, 2020
@oskarth
Copy link
Contributor Author

oskarth commented Jul 28, 2020

Should we turn off this double reviewing, kind of annoying

@oskarth oskarth merged commit 7fa0419 into master Jul 28, 2020
@oskarth oskarth deleted the feature/waku-v2-historical-sketch branch July 28, 2020 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants