Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

38/LOGOS-CONSENSUS-GLACIER #512

Merged
merged 65 commits into from
Dec 6, 2022
Merged

38/LOGOS-CONSENSUS-GLACIER #512

merged 65 commits into from
Dec 6, 2022

Conversation

easye
Copy link
Contributor

@easye easye commented Jul 1, 2022

c.f. #509

Ongoing pull request towards an initial Logos Consensus RFC

@easye easye self-assigned this Jul 1, 2022
@easye easye marked this pull request as draft July 1, 2022 12:01
@easye easye requested a review from kaiserd July 1, 2022 12:02
@easye easye changed the title 38/LOGOS-CONSENSUS RFC initial TOC 38/LOGOS-CONSENSUS RFC initial TOC ff. Jul 1, 2022
@kaiserd
Copy link
Contributor

kaiserd commented Jul 1, 2022

Thanks for starting this PR.
Imo, the focus should be on aspects that are important for implementors.
So, the more background related sections could be left as placeholders / filled with a rough sketch for now.

@kaiserd
Copy link
Contributor

kaiserd commented Jul 1, 2022

I'd suggest adding a section for Wire Format Specification / Syntax after Exposition of Snow-family Consensus Models
( In #488, I generically described what could/should be in that section.)

Also adding a "security" section like Security/Privacy Considerations whould be helpful.
The contents can be a rough sketch for the raw version of the RFC.

You can also use the following copyright section:

# Copyright

Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).

@easye easye changed the title 38/LOGOS-CONSENSUS RFC initial TOC ff. 38/LOGOS-CONSENSUS RFC Jul 1, 2022
easye added a commit that referenced this pull request Jul 1, 2022
@oskarth
Copy link
Contributor

oskarth commented Jul 5, 2022

Where's the content? I see nothing that relates to actual consensus mechanism. It shouldn't take that long to get basic semantics done considering a lot has been written already

## In Media Res

We begin--as all worthwhile journeys begin--in the middle of things,
desiring to communciate a whole without knowing the exact shape of the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

communicate*

The use of semantic line breaks https://sembr.org/ is recommended https://rfc.vac.dev/spec/1/#conventions

Copy link
Contributor Author

@easye easye Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of semantic line breaks https://sembr.org/ is recommended https://rfc.vac.dev/spec/1/#conventions

Choosing to not implement this suggestion for the moment, as manual paragraph filling is part of my re-writing process.

  • But I'll definitely take this as a TODO for exiting the RAW specification state to not confuse upstream consumers.

Copy link
Contributor Author

@easye easye Aug 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem that the inclusion of line breaks is affecting downstream Markdown consumer's notion of paragraphs.

But will double check before we enter draft raw.

content/docs/rfcs/38/README.md Outdated Show resolved Hide resolved
@easye easye requested a review from corpetty August 5, 2022 22:44
@easye easye added the track:logos-specs Logos specs track (RAD) label Aug 5, 2022
@oskarth
Copy link
Contributor

oskarth commented Aug 9, 2022

What is needed before this is ready for review / mergeable? What about being draft (does this even make sense given current state?) Does it reflect and capture all relevant current knowledge in e.g. Notion?

@easye
Copy link
Contributor Author

easye commented Aug 9, 2022

What is needed before this is ready for review / mergeable? What about being draft (does this even make sense given current state?) Does it reflect and capture all relevant current knowledge in e.g. Notion?

  • Camera-ready edit of text
  • Confirm how markdown renders locally (using Pandoc 2.18 current; Github preview is not ready)
  • Alvaro's contributor status clear
  • pseudo-code description of Glacier accurate
  • review by end of August from at least two Logos contributors
    • Increase Logos Github familiarity for those who need it

@easye easye marked this pull request as ready for review August 9, 2022 06:50
content/docs/rfcs/38/README.md Outdated Show resolved Hide resolved
@easye
Copy link
Contributor Author

easye commented Aug 10, 2022

Where's the content? I see nothing that relates to actual consensus mechanism.

A base pseudo-code exposition of Glacier now exists. It needs editing, but is largely correct. Main problem is describing termination accurately.

@easye
Copy link
Contributor Author

easye commented Aug 10, 2022

I'd suggest adding a section for Wire Format Specification / Syntax after Exposition of Snow-family Consensus Models

Resolved.

Security/Privacy Considerations whould be helpful.

See the "Sovereignty Considerations" section. Thanks!

# Copyright

Added.

@kaiserd kaiserd force-pushed the easye/consensus-rfc/20220701a branch from f6e123c to 90360fe Compare December 6, 2022 09:53
@kaiserd
Copy link
Contributor

kaiserd commented Dec 6, 2022

I rewrote the history to sign unsigned commits:

  • remove merged-in commits form master (otherwise, we cannot cleanly rebase on master at the end)
  • sigend all commits in this PR
  • rebased on master

With this, we can close this PR.
Thanks to all who have contributed :).

@kaiserd kaiserd merged commit 86eb2da into master Dec 6, 2022
@kaiserd kaiserd deleted the easye/consensus-rfc/20220701a branch December 6, 2022 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
track:logos-specs Logos specs track (RAD)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants