Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Security considerations #60

Merged
merged 10 commits into from
Dec 5, 2019
Merged

Security considerations #60

merged 10 commits into from
Dec 5, 2019

Conversation

oskarth
Copy link
Contributor

@oskarth oskarth commented Dec 3, 2019

Addresses #39

@oskarth oskarth changed the title Initial cut Security considerations Dec 3, 2019
waku.md Outdated Show resolved Hide resolved
waku.md Outdated Show resolved Hide resolved
waku.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kdeme kdeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, some small remarks


Privacy for Whisper / Waku haven't been studied rigorously for various threat models like global passive adversary, local active attacker, etc. This is unlike e.g. Tor and mixnets.

**Topic hygiene:**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this needs to be a separate section. As, in theory, this only applies when you are a light node or when you are connecting with a mailserver (and in v1 when you are a Waku client).
In the other scenarios this should be fine as peers will not know who a message comes from, or is intended for.

It is different for bloom filter as peers specifically broadcast their filter setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, where would you put it? Something like this:

If you use a very specific topic you reveal more information.

under light client privacy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't know. I guess it can stay there

waku.md Outdated Show resolved Hide resolved
@oskarth oskarth force-pushed the security-considerations branch from 3952251 to a77c1ef Compare December 3, 2019 12:08
@oskarth oskarth force-pushed the security-considerations branch from a77c1ef to 903c1b1 Compare December 3, 2019 12:09
Copy link
Contributor

@decanus decanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a couple of changes

waku.md Outdated Show resolved Hide resolved
waku.md Outdated Show resolved Hide resolved
oskarth and others added 2 commits December 4, 2019 11:38
Co-Authored-By: Dean Eigenmann <dean.eigenmann@icloud.com>
Co-Authored-By: Dean Eigenmann <dean.eigenmann@icloud.com>
@oskarth oskarth merged commit 4b2a6c6 into master Dec 5, 2019
@oskarth oskarth deleted the security-considerations branch December 5, 2019 03:26
kdeme pushed a commit that referenced this pull request May 18, 2020
* Initial cut

* scalability ux section

* moar

* version and toc

* fix port

* clarify bloom

* update bw usage link to version controlled

* remove mvds refer

* Update waku.md

Co-Authored-By: Dean Eigenmann <dean.eigenmann@icloud.com>

* Update waku.md

Co-Authored-By: Dean Eigenmann <dean.eigenmann@icloud.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants