-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, some small remarks
|
||
Privacy for Whisper / Waku haven't been studied rigorously for various threat models like global passive adversary, local active attacker, etc. This is unlike e.g. Tor and mixnets. | ||
|
||
**Topic hygiene:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this needs to be a separate section. As, in theory, this only applies when you are a light node or when you are connecting with a mailserver (and in v1 when you are a Waku client).
In the other scenarios this should be fine as peers will not know who a message comes from, or is intended for.
It is different for bloom filter as peers specifically broadcast their filter setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, where would you put it? Something like this:
If you use a very specific topic you reveal more information.
under light client privacy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cammellos @adambabik wdyt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't know. I guess it can stay there
3952251
to
a77c1ef
Compare
a77c1ef
to
903c1b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just a couple of changes
Co-Authored-By: Dean Eigenmann <dean.eigenmann@icloud.com>
Co-Authored-By: Dean Eigenmann <dean.eigenmann@icloud.com>
* Initial cut * scalability ux section * moar * version and toc * fix port * clarify bloom * update bw usage link to version controlled * remove mvds refer * Update waku.md Co-Authored-By: Dean Eigenmann <dean.eigenmann@icloud.com> * Update waku.md Co-Authored-By: Dean Eigenmann <dean.eigenmann@icloud.com>
Addresses #39