Protocol Fees (Set to 20%) #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
approved these changes
Aug 25, 2022
staheri14
reviewed
Aug 29, 2022
| @@ -86,7 +88,8 @@ contract RLN { | |||
| members[_pubkeyIndex] = 0; | |||
|
|
|||
| // refund deposit | |||
| (bool sent, _) = receiver.call{value: MEMBERSHIP_DEPOSIT}(""); | |||
| uint256 withdrawableDeposit = MEMBERSHIP_DEPOSIT * (WAD - PROTOCOL_FEES_PERCENTAGE) / WAD | |||
| (bool sent, _) = receiver.call{value: withdrawableDeposit}(""); | |||
There was a problem hiding this comment.
Please also add comments next to each code line to elaborate on what is happening.
There was a problem hiding this comment.
Please also add comments next to each code line to elaborate on what is happening.
@kgrgpg Once the comment is addressed, let me know to re-review.
|
Also, following our call, please create an issue for passing the fee percentage as a constructor argument (instead of being hardcoded). |
|
@staheri14 The protocol fees setting via constructor issue can be found at #8 |
|
Closing this PR as tokenomics hasn't been allotted to rlnp2p, yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation for incorporating the fees that will be reserved for protocol usage. The commission collected can be used for incentivising different stakeholders. The current fees is set to 20 % and hard coded to take into account the format of decimals in solidity language. This code only aims to hold back the commission and does not show how to utilise or withdraw it from the contract at the moment. The issue for the same can be found at vacp2p/rfc#485